PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defining the CollectiveCommunication.
|
jenkins build this please |
|
Any objections of this being merged? |
atgeirr
reviewed
Dec 16, 2019
opm/grid/polyhedralgrid/geometry.hh
Outdated
| @@ -130,26 +135,24 @@ namespace Dune | |||
| PolyhedralGridBasicGeometry ( ExtraData data, const EntitySeed& seed ) | |||
| : storage_( data, seed ) | |||
| { | |||
| GeometryType myType = type(); | |||
| /* | |||
There was a problem hiding this comment.
Is it important to keep the commented-out code?
I do not mind merging this when Jenkins is green.
dr-robertk
force-pushed
the
PR/bugfix-polyhedral-comm
branch
from
b1f2f35
to
ff6dc6e
Compare
|
jenkins build this please |
|
@atgeirr: I removed the unused code. |
actually needed.
dr-robertk
force-pushed
the
PR/bugfix-polyhedral-comm
branch
from
ff6dc6e
to
b5e621e
Compare
|
jenkins build this please |
|
The test of polyhedralgrid fails due to a degenerated element (volume near zero). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compilation issue with ebos.