Adds Verteq (Vertical Equilibrium) Grid #512
Conversation
a proper DGF implementation for Polyhedron and Polygon.
avoid false destruction.
|
Welcome to OPM. Thanks a lot for the contribution. I am sure this is very valuable but you could make our life a bit easier to assess and understand the value. Please think about doing this (would be very welcome):
|
|
The verteq (Vertical Equilibrium) is a revitalization of a former OPM project called verteq from some years back. It basically allows to colaps a column of grid cells from a corner point grid into a 2d cell while keeping a way of communicating between the two grids. This is used for longterm (>100 years) large scale (large reservoirs) CO2 simulations. The original code from Roland was based on UnstructuredGrid and thus with this PR we try to revitalize some of that code to be used in present day OPM. I think @totto82 can give you the full picture and @atgeirr can fill you in on the history. |
blattms
changed the title
There was a problem hiding this comment.
Thanks for providing the PR. I know this is not purely your work, so thanks for the effort of trying to get it into the master code. Some cleanup and I think this can be merged. I agree with @blattms that a rebase -i to squash some of the commits would be helpful. Just give me a hint if you need guidance in what commits that needs be squashed together. Getting the VE code back in shape is a valuable contribution IMO.
| @@ -0,0 +1,253 @@ | |||
| #ifndef DUNE_POLYHEDRALGRID_MESH_HH | |||
There was a problem hiding this comment.
The polyhedralmesh.hh is according to @dr-robertk a WIP reimplementation of the unstructured grid and should be removed from this PR.
| template <class Grid> | ||
| void testGrid(Grid& grid, const std::string& name, const size_t nElem, const size_t nVertices) | ||
| { | ||
| typedef typename Grid::LeafGridView GridView; | ||
| /* | ||
| //testVerteq( grid ); | ||
|
|
There was a problem hiding this comment.
Please add back the gridcheck test for the standard grid. Also it would be useful to add the testVerteq test. But maybe not as part of testGrid but called independently.
The verteq (Vertical Equilibrium) is a revitalization of a former OPM project called verteq from some years back. It basically allows to colaps a column of grid cells from a corner point grid into a 2d cell while keeping a way of communicating between the two grids. This is used for longterm (>100 years) large scale (large reservoirs) CO2 simulations.
The above is copied from below to make it easier to find.