Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the failure flag of the tasklet runner to detect a failure while … #5478

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

lisajulia
Copy link
Contributor

…writing output and throw an error if that happens.

@lisajulia
Copy link
Contributor Author

lisajulia commented Jul 12, 2024

jenkins build this opm-models=909 please

…writing output and throw an error if that happens
@lisajulia lisajulia force-pushed the feature/add-failureFlag-to-tasklets branch from f8b653f to e2126ae Compare July 15, 2024 06:55
@lisajulia
Copy link
Contributor Author

@bska: Can you have a look here? Thanks!

@lisajulia
Copy link
Contributor Author

jenkins build this please

@lisajulia lisajulia requested a review from bska July 15, 2024 15:37
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and I'll merge into master. We do need to take the next step of guarding the call to doWriteOutput() at some point, but that can be follow-up work.

@bska bska merged commit 6ce61a9 into OPM:master Jul 16, 2024
1 check passed
@lisajulia lisajulia deleted the feature/add-failureFlag-to-tasklets branch July 19, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants