Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with stopped injectors in thermal runs #5605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

totto82
Copy link
Member

@totto82 totto82 commented Sep 13, 2024

No description provided.

@totto82
Copy link
Member Author

totto82 commented Sep 13, 2024

jenkins build this please

@totto82 totto82 requested a review from hnil September 20, 2024 10:35
@totto82 totto82 marked this pull request as ready for review September 20, 2024 10:36
@totto82
Copy link
Member Author

totto82 commented Sep 23, 2024

jenkins build this please

Copy link
Member

@hnil hnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably of given the current temperature model for wells, but there maybe issures:

  1. For injecting perforations of injectors: l 2619 calculate enthalpy potentially with pressure and temperature from different plases i.e. temperature for injection (top well), but pressure from perforation.
  2. For injecting perforations for produces (not(injectors) which is stopped) enthalpy is taken from reservoir at the cell... and derivatives is lost. This is probably a hack which is ok until temperature/enthalpy is added to wells. It also maybe "inconsistent" with output which set the "temperature" in the well to an average of producing perforations (but this would give dynamic large coplings in the model).

@totto82
Copy link
Member Author

totto82 commented Sep 26, 2024

This is probably of given the current temperature model for wells, but there maybe issures:

  1. For injecting perforations of injectors: l 2619 calculate enthalpy potentially with pressure and temperature from different plases i.e. temperature for injection (top well), but pressure from perforation.
  2. For injecting perforations for produces (not(injectors) which is stopped) enthalpy is taken from reservoir at the cell... and derivatives is lost. This is probably a hack which is ok until temperature/enthalpy is added to wells. It also maybe "inconsistent" with output which set the "temperature" in the well to an average of producing perforations (but this would give dynamic large coplings in the model).
  1. Do you suggest to use bhp?
  2. I am open for using the average well temperature, but I am not sure how much it will impact the solution. The ideal solution is probably to add temperature as an variable to the MSW. With this we could actually model the heat transport in the well.

Do you want me to address some of these issues in this PR, or is that for another day. I think this PR fixes a actual bug as the well temperature from the input was used for stopped wells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants