Reservoir coupling: Implement time stepping #5620
Conversation
Okay, in that case I'm going to mark this as "work in progress/draft" to avoid inadvertent merging. |
@bska Thanks. I was actually planning to get this merged, since it is becoming difficult to handle all the dependent PRs and keep them up to date. Is this a good idea, or should I wait until the complete reservoir coupling feature is ready? |
It is a very good idea. Do not wait for the complete feature, unless you expect significant changes to the parts you already did. This patch has grown to become quite large, so finishing and polishing the first PRs in the series so they can be merged should be a high priority. |
hakonhagland
force-pushed
the
timestepping2
branch
3 times, most recently
from
ac5ff0f
to
27a09b4
Compare
Do not specify slave program name twice when launching slave process
Open MPI does not support output redirection for spawned child processes.
Copy command line parameters from master to slave command line. Also replace data file name in master argv with data file name of the slave.
Remove debug code that was introduced by mistake in the previous commit
Create one log file for each slave subprocess. Redirect both stdout and stderr to this file
Exclude the reservoir coupling stuff if MPI is not enabled
Implement adaptive time stepping for master and slave procesess when using reservoir coupling. The original adaptive time stepping method is refactored at the same time.
hakonhagland
force-pushed
the
timestepping2
branch
from
27a09b4
to
290f18e
Compare
Builds on #5521 which should be merged first.
Also refactors the original adaptive time stepping method.