Update THP also for zero-rate wells #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this failure_report please |
|
Only one of the tests show considerable differences here ( |
GitPaean
approved these changes
Sep 27, 2024
|
jenkins build this update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Sep 27, 2024
Reason: PR OPM/opm-simulators#5634 opm-common = 27a6e80523b7cfa5997befed3323c4afced1ac81 opm-grid = 36069f06e5fe321c2dd161a7614dc95be5d05978 opm-models = 62142127b6cfe01fa507db3b8bbff402d1ab573d opm-simulators = 62142127b6cfe01fa507db3b8bbff402d1ab573d ### Changed Tests ### * model4_udq_group * model4_gefac * min_thp_1 * actionx_wpimult * wvfpexp_02 * 01_wgrupcon * 02_wgrupcon
|
jenkins build this opm-tests=1233 please |
GitPaean
added a commit
to OPM/opm-tests
that referenced
this pull request
Sep 27, 2024
Automatic Reference Data Update for PR OPM/opm-simulators#5634
|
The updated reference is installed. I am getting this PR in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
updateThp, the thp is set to zero if the well is stopped or set to zero rate (individual or group). This is problematic for cases where e.g., a well temporarily gets assiged a zero rate from group as the zero thp subsequently will be interpreted as a thp-limit violation. This PR simply suggests to always update thp as long as the vfp is active (we have reasonnable fallbacks for zero rate vfp-interpolation).