Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpmaint for region 0 #5916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix gpmaint for region 0 #5916

wants to merge 1 commit into from

Conversation

totto82
Copy link
Member

@totto82 totto82 commented Jan 24, 2025

region 0 means the whole field

Depends on OPM/opm-common#4447

Fix gpmaint for region 0
13d57ce 
region 0 means the whole field
@totto82 totto82 requested a review from bska January 27, 2025 07:42
bska
bska reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but as far as I can tell the defineState() function isn't called anywhere so I don't really know what problem we're addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totto82 @bska