-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Dynamic Dispatch Function to Separate TU #5928
Conversation
I am not sure that this is the best way to go about solving my problem, but my main goal here–in support of #5801–is to make I welcome all suggestions for alternative strategies here. |
jenkins build this please |
44d17aa
to
1b292cc
Compare
This entirely makes sense to me, but we need to make the FlowProblemTPFA available in some contexts where it is now missing (build with python). While that particular problem is solvable by including flow_blackoil.hpp in PyMain.hpp, for ..reasons (some machine learning extensions for flow that i'm maintaining), I'd really like if we could put it in a separate (installed) header. |
1b292cc
to
2c84bcd
Compare
Right. I made this PR based on a build configuration without
PR #5930 does essentially this.
The |
yes please. while it is very few lines of code, I'd really like to not duplicate them in my downstream. It can potentially mean ODR violations should anything change and that is more maintenance... |
👍 Any preference for the location? Do we still keep it in opm-simulators/flow, or is there some other location that might be better? |
i'd say put it in opm/simulators/flow to keep the opm-simulators/flow folder strictly no-install. |
Good idea. Please have a look at PR #5931. |
b77e9fe
to
5e5b32b
Compare
The earlier, preparatory, PRs have been merged. I'm marking this as "ready for review" and I welcome any comments you may have. |
jenkins build this please |
This moves about 300 lines of code out of Main.hpp and, especially, moves the <flow/flow_*.hpp> include statements as well. This, in turn, makes Main::runStatic<>() usable for out-of-tree consumers.
5e5b32b
to
1bf755f
Compare
jenkins build this please |
PR approved and build check is green. I'll merge into master. |
This moves about 300 lines of code out of
Main.hpp
and, especially, moves the<flow/flow_*.hpp>
include statements as well. This, in turn, makesMain::runStatic<>()
usable for out-of-tree consumers.