Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default component names and image tags in Helm templates #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kronk74
Copy link

@Kronk74 Kronk74 commented Dec 4, 2024

Hi,

I had trouble to set custom image in your helm charts. Here is a little change to manage (I think) better helm chart components.

The documentation is not complete. It need to be review.

Not tested yet but it is a proposal.

Have a nice day,

@schesa schesa self-requested a review December 5, 2024 13:24
@schesa
Copy link
Collaborator

schesa commented Dec 5, 2024

Hi @Kronk74 ,

Thank you for your contribution and for proposing improvements to the Helm charts. Your input is highly valued, and we appreciate your effort to enhance the project.

I’ve left a few comments for your review, and we’ll integrate the key ideas into our private repository first to ensure they pass through our internal pipeline before doing the next release.

@Kronk74
Copy link
Author

Kronk74 commented Dec 16, 2024

Hi,

Thanks for your return but I don't see any review/comment. Can you verify that your comments are saved ?
I'm not a big user of github, maybe I didn't see it because I was in a wrong tab...

Regards,

@pablohernandezops
Copy link
Collaborator

Hi @Kronk74 we have just released a change in the template for the pg pod for ICAP, it was missing an option to use a custom repo, thank you for your feedback on that.
Regarding the default component names and image tag, we have decided not to make those changes for the moment. You can still use the icap_docker_repo for the repo name and the image field to indicate both the name and the tag at once.

if you have any additional issue with you custom repo after these new release please contact support which will be happy to help you.

Regards
and again thank you for valuable feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants