Fix tuple runtime #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongey
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Everything in this PR builds and runs okay on my end. Only glitch is that the qirxacc_XaccQuantumTest fails but this is because qsim is not activated in XACC's minimal build for QIREE. I would say we should probably deactivate this test for the time being (I will create an issue for it).
The option --group-tuples works well for qwerty-generated QIR in the base profile. No errors there!
|
PR #11 addresses the issue in my previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #4 which fails to compile with the clang on my mac.