Working Example of Solving RLCircuit and Microgrid with Jacobians #1

reid-g · 2024-02-26T22:42:54Z

Added Jacobian Composing
Added IDA solving with Jacobians using KLU
Added basic circuit components
- Added resistor, capacitor, voltage source, and inductor
- Residuals and jacobians for each
Added components for microgrid:
- Added Microgrid DiscreteGenerate, line, load, and bus
- Residuals and jacobians for each
Working examples with verifications

pelesh · 2024-03-11T22:51:23Z

The branch composer-dev fails to build due to apparent CMake bug. The build fails with a message:

ld: library 'suitesparseconfig' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Solver/Dynamic/libgridkit_solvers_dyn.0.0.7.dylib] Error 1
...

The library is there on the build line, but there are also flags like -lsuitesparseconfig, which are (1) duplicates and (2) don't have library path specified. Removing these flags manually fixes the local problem. Appropriate changes need to be made in the CMake functions. See verbose output on the linker line:

[ 60%] Linking CXX shared library libgridkit_solvers_dyn.dylib
cd /Users/55y/src/gridkit/build-clang/Solver/Dynamic && /opt/local/bin/cmake -E cmake_link_script CMakeFiles/solvers_dyn_shared.dir/link.txt --verbose=1
/opt/local/bin/clang++ -Wall -O0 -g -DDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -dynamiclib -Wl,-headerpad_max_install_names -current_version 0.0.7 -o libgridkit_solvers_dyn.0.0.7.dylib -install_name @rpath/libgridkit_solvers_dyn.0.dylib CMakeFiles/solvers_dyn_obj_shared.dir/Ida.cpp.o  -lsuitesparseconfig -lklu -lamd -lcolamd /Users/55y/local/sundials-clang/lib/libsundials_nvecserial.6.1.1.dylib /Users/55y/local/sundials-clang/lib/libsundials_idas.5.1.1.dylib /Users/55y/local/sundials-clang/lib/libsundials_sunlinsolklu.4.1.1.dylib /Users/55y/local/sundials-clang/lib/libsundials_sunmatrixsparse.4.1.1.dylib /opt/local/lib/libklu.dylib /opt/local/lib/libamd.dylib /opt/local/lib/libcolamd.dylib /opt/local/lib/libbtf.dylib /opt/local/lib/libsuitesparseconfig.dylib

pelesh

Need to fix build issue with SuiteSparse libraries.

pelesh · 2024-03-11T23:42:35Z

@balos1, it seems to me this issue is coming somewhere from SUNDIALS configuration. I am linking GridKit to SUNDIALS v6.1.1 on my Macbook.

pelesh

Great work and many helpful tests added to verify implementations.

There are a few things that need to be done before composer-dev branch is ready to merge:

The branch needs to be rebased with respect to develop.
Indentation in the code does not follow the GridKit coding style. I suggest fixing the indentation first, because this will make rebasing easier.
Bug in CMake that affects linking to KLU needs fixing.
Adjoint sensitivity test fails. Needs investigating.
Might be good to rename classes named "discrete generator" to "distributed generator".
It seems that finding Ipopt is broken in this branch. Needs fixing.

Examples/DiscreteGeneratorTest/DGTest.cpp

Solver/Dynamic/CMakeLists.txt

pelesh · 2024-03-12T13:51:34Z

@balos1, it seems to me this issue is coming somewhere from SUNDIALS configuration. I am linking GridKit to SUNDIALS v6.1.1 on my Macbook.

I stand corrected, this issue originates in GridKit. See above.

Parse load data from the input file. Check load data when testing Matpower parser. Do not store load data in bus data structure. Changed names and order of template parameters in power system data structures. More intuitieve data structures names Changed names of data structures to distinguish Matpower specific data and general power system description data. Pass correct scalar and real types to derived bus classes. Add generator base and slack classes. Classes compile correctly, not tested yet. Infrastructure for adding buses and generators to power flow models Add steady-state generator models and factory. Constructors now read directly from GenData and BusData structures. Updated Bus classes accordingly. Usage example provided in Grid3BusSys app. Supporting infrastructure for Loads and Branches Expanded methods for adding components to the power system grid. Includes new constructors for loads and branches, as well as methods for accessing buses through their IDs. Updated Parsing Example Fixed Memory Errors in KinSol and SystemSteadyStateModel +Clean valgrind output Prototype Example of Creating a RL Circuit +Add hypergraph representation +Added Model form with appropiate indexing +Added Resistors, Capacitor, Inductor, and VoltageSource Component Models Add capability to build power flow models from Matpower input files Use more realistic test passing criterion Release 0.0.7 updates

+Added InductionMotor, Linear Transformer, and SynchronousMachine +Changes to PowerElectronicsModel

+ Basic COO Sparse Matrix Implmentation + Discrete Generator Component + Resistor Jacobian + Capacitor Jacobian + Voltage Source Jacobian + Inductor Jacobian + Testing for Sparse Jacobian and Discrete Generator

…rices +Matrix Assembly +Refactored COO Matrix +COO can return CSR Data format

+ Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques

- Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example

- "grounded" the rotor difference in reference - Comparing agianst reference from MATLAB

Co-authored-by: pelesh <peless@ornl.gov>

- Updated name of generator - Some formatting updates

- Fixed SpMatTest - Updates on rebase

- Intalized Pg data

Fix max number of backward steps in IDA solver.

* Merge Ida Fix * Fixed Whitespace Editor Changes * Tabs to Spaces Ida.cpp

+ Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques

- Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example

- "grounded" the rotor difference in reference - Comparing agianst reference from MATLAB

Co-authored-by: pelesh <peless@ornl.gov>

- Updated name of generator - Some formatting updates

- Fixed SpMatTest - Updates on rebase

- Intalized Pg data

* Merge Ida Fix * Fixed Whitespace Editor Changes * Tabs to Spaces Ida.cpp

- Update format - Fixed casting warnings

…omposer-dev

pelesh

This is partial review flagging some minor issues in the code just to move them out of way. A more detailed code review is needed to check models.

CMakeLists.txt

CircuitGraph.hpp

ComponentLib/Bus/BusSlack.cpp

ComponentLib/PowerElectronicsComponents/Capacitor/Capacitor.cpp

ComponentLib/PowerElectronicsComponents/SynchronousMachine/SynchronousMachine.cpp

Examples/DistributedGeneratorTest/CMakeLists.txt

Examples/Microgrid/CMakeLists.txt

Solver/Dynamic/CMakeLists.txt

Solver/Dynamic/Ida.hpp

Co-authored-by: Reid <reid-g@users.noreply.github.com>

Solver/Dynamic/CMakeLists.txt

- Updated Comments to respect current models - Fixed valgrind errors in ida.cpp. Note: there is still more but seg faults are happening from frees

- Removed this-> with usings for formatting - Added using for Jac to components which did not have

pelesh

Major issues addressed, all tests pass.

Prototype Example of Creating a RL Circuit +Add hypergraph representation +Added Model form with appropiate indexing +Added Resistors, Capacitor, Inductor, and VoltageSource Component Models +Added InductionMotor, Linear Transformer, and SynchronousMachine +Changes to PowerElectronicsModel * Added COO Sparse Matrices, Component Jacobians, and Discrete Generator + Basic COO Sparse Matrix Implmentation + Discrete Generator Component + Resistor Jacobian + Capacitor Jacobian + Voltage Source Jacobian + Inductor Jacobian + Testing for Sparse Jacobian and Discrete Generator * Added Jacobian Assembly. Fixed and Added New Functionality to COO Matrices +Matrix Assembly +Refactored COO Matrix +COO can return CSR Data format * Jacobian Assembly, IDA + KLU Cmake, RL Circuit + Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques * Added the Transmission Line Component * Added Microgrid Example - Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example * Working Microgrid (Finite Difference) - "grounded" the rotor difference in reference - Comparing against reference from MATLAB * Fixed the Jacobian in Microgrid Example * Added a max step size control for model objects * Update Solver/Dynamic/CMakeLists.txt Co-authored-by: pelesh <peless@ornl.gov> * Updated name DiscreteGenerator -> DistributedGenerator - Updated name of generator - Some formatting updates * Fixed Some Bugs - Fixed SpMatTest - Updates on rebase * Fixed Memory Error with Grid3BusSys - Intalized Pg data * Fixed Unitalized Variable Stepsize * Remove parts of generator model from BusPV (#7) * Formatting updates + Fixed Warnings - Update format - Fixed casting warnings * Minor comments and style corrections. Co-authored-by: Reid <reid-g@users.noreply.github.com> * Multiple Format & Comment Updates + Valgrind Error Fixes - Updated Comments to respect current models - Fixed valgrind errors in ida.cpp. Note: there is still more but seg faults are happening from frees * Formatting Updates with "this" and using + Minor Fixes - Removed this-> with usings for formatting - Added using for Jac to components which did not have * Added Better Description to the MicrogridBus --------- Co-authored-by: Slaven Peles <peless@ornl.gov> Co-authored-by: Reid <reid-g@users.noreply.github.com>

reid-g added the enhancement New feature or request label Feb 26, 2024

reid-g requested a review from pelesh February 26, 2024 22:42

reid-g self-assigned this Feb 26, 2024

pelesh requested changes Mar 11, 2024

View reviewed changes

pelesh requested changes Mar 12, 2024

View reviewed changes

Examples/DiscreteGeneratorTest/DGTest.cpp Outdated Show resolved Hide resolved

Solver/Dynamic/CMakeLists.txt Show resolved Hide resolved

pelesh and others added 12 commits March 12, 2024 13:15

Add New Components and Changes to Composition

1603057

+Added InductionMotor, Linear Transformer, and SynchronousMachine +Changes to PowerElectronicsModel

Added COO Sparse Matrices, Component Jacobians, and Discrete Generator

b9ce19f

+ Basic COO Sparse Matrix Implmentation + Discrete Generator Component + Resistor Jacobian + Capacitor Jacobian + Voltage Source Jacobian + Inductor Jacobian + Testing for Sparse Jacobian and Discrete Generator

Added Jacobian Assembly. Fixed and Added New Functionality to COO Mat…

be22b55

…rices +Matrix Assembly +Refactored COO Matrix +COO can return CSR Data format

Jacobian Assembly, IDA + KLU Cmake, RL Circuit

3f74458

+ Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques

Added the Transmission Line Component

a42761c

Added Microgrid Example

fcf1cb9

- Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example

Working Microgrid (Finite Difference)

1aa8865

- "grounded" the rotor difference in reference - Comparing agianst reference from MATLAB

Fixed the Jacobian in Microgrid Example

723c785

Added a max step size control for model objects

a3e5af8

Update Solver/Dynamic/CMakeLists.txt

c3f071e

Co-authored-by: pelesh <peless@ornl.gov>

Updated name DiscreteGenerator -> DistributedGenerator

7be79c7

- Updated name of generator - Some formatting updates

reid-g force-pushed the composer-dev branch from 5abfa66 to 7be79c7 Compare March 12, 2024 17:28

reid-g and others added 5 commits March 12, 2024 16:23

Fixed Some Bugs

d715372

- Fixed SpMatTest - Updates on rebase

Fixed Memory Error with Grid3BusSys

001d3c2

- Intalized Pg data

Fixed Unitalized Variable Stepsize

d258ad5

Fix max number of backward steps in IDA solver.

c8de307

Merge pull request #4 from ORNL/composer-ida-fix

36df264

Fix max number of backward steps in IDA solver.

pelesh mentioned this pull request Apr 9, 2024

Add brief style guidelines. #5

Merged

Fixing indentation from tabs to spaces

31e6f68

pelesh mentioned this pull request Apr 9, 2024

Formatting Fix Composer-Dev #6

Merged

Formatting Fix Composer-Dev (#6)

f8d6943

* Merge Ida Fix * Fixed Whitespace Editor Changes * Tabs to Spaces Ida.cpp

reid-g and others added 17 commits April 10, 2024 15:52

Jacobian Assembly, IDA + KLU Cmake, RL Circuit

1dc614c

+ Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques

Added the Transmission Line Component

e005183

Added Microgrid Example

eb6fde4

- Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example

Working Microgrid (Finite Difference)

1952b25

- "grounded" the rotor difference in reference - Comparing agianst reference from MATLAB

Fixed the Jacobian in Microgrid Example

efc71f8

Added a max step size control for model objects

9f99077

Update Solver/Dynamic/CMakeLists.txt

60b328c

Co-authored-by: pelesh <peless@ornl.gov>

Updated name DiscreteGenerator -> DistributedGenerator

6c223b3

- Updated name of generator - Some formatting updates

Fixed Some Bugs

226afca

- Fixed SpMatTest - Updates on rebase

Fixed Memory Error with Grid3BusSys

861b33c

- Intalized Pg data

Fixed Unitalized Variable Stepsize

efddb28

Fix max number of backward steps in IDA solver.

3cb53a8

Fixing indentation from tabs to spaces

a2e71ab

Formatting Fix Composer-Dev (#6)

17a0cb7

* Merge Ida Fix * Fixed Whitespace Editor Changes * Tabs to Spaces Ida.cpp

Formatting updates + Fixed Warnings

d2ac21a

- Update format - Fixed casting warnings

Rebasing with BusPV Fixes

a192d47

Merge branch 'composer-dev' of https://github.com/ORNL/GridKit into c…

b0c02a1

…omposer-dev

pelesh requested changes Apr 12, 2024

View reviewed changes

Minor comments and style corrections.

ad7f4af

Co-authored-by: Reid <reid-g@users.noreply.github.com>

pelesh reviewed Apr 15, 2024

View reviewed changes

Solver/Dynamic/CMakeLists.txt Show resolved Hide resolved

This was referenced Apr 15, 2024

Create an interface target to add debug symbols #8

Open

Link to SUNDIALS KLU module only when KLU support in GridKit is enabled. #9

Closed

reid-g added 3 commits April 16, 2024 16:17

Multiple Format & Comment Updates + Valgrind Error Fixes

7e685c5

- Updated Comments to respect current models - Fixed valgrind errors in ida.cpp. Note: there is still more but seg faults are happening from frees

Formatting Updates with "this" and using + Minor Fixes

a43404f

- Removed this-> with usings for formatting - Added using for Jac to components which did not have

Added Better Description to the MicrogridBus

9250411

pelesh approved these changes May 3, 2024

View reviewed changes

pelesh merged commit 753aecc into develop May 3, 2024

pelesh deleted the composer-dev branch March 14, 2025 03:33

pelesh mentioned this pull request May 21, 2025

SUNDIALS updates #105

Merged

6 tasks

Working Example of Solving RLCircuit and Microgrid with Jacobians #1

Working Example of Solving RLCircuit and Microgrid with Jacobians #1

Uh oh!

Conversation

reid-g commented Feb 26, 2024

Uh oh!

pelesh commented Mar 11, 2024

Uh oh!

pelesh left a comment

Choose a reason for hiding this comment

Uh oh!

pelesh commented Mar 11, 2024

Uh oh!

pelesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pelesh commented Mar 12, 2024

Uh oh!

pelesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pelesh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants