-
Notifications
You must be signed in to change notification settings - Fork 7
Fix load Jacobian #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix load Jacobian #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
780f4ce to
ae1e084
Compare
ae1e084 to
204a514
Compare
pelesh
approved these changes
May 15, 2025
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue fixed!
Collaborator
Author
Waiting for CI. I mistakenly pushed a Spack update I had locally. Let's see if I can revert it. |
4107910 to
35ea975
Compare
4f008ef to
4fa61cf
Compare
798e302 to
dbabcf8
Compare
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Fix load Jacobian. * Upgrade base image id to build a new cache. * Spack concretizer unify. * Rename GH CI test. * Create new local-buildcache and push to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #107
Proposed changes
Changed signs in the analytical Jacobian for the load to match changes in #85.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Rebuilt the GH Actions build cache and set it up so that a new build cache is created when the base image version changes.