Skip to content

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented May 15, 2025

Description

Closes #107

Proposed changes

Changed signs in the analytical Jacobian for the load to match changes in #85.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

Rebuilt the GH Actions build cache and set it up so that a new build cache is created when the base image version changes.

@nkoukpaizan nkoukpaizan requested review from abirchfield and pelesh May 15, 2025 16:25
@nkoukpaizan nkoukpaizan self-assigned this May 15, 2025
@nkoukpaizan nkoukpaizan added the bug Something isn't working label May 15, 2025
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-load-Jacobian branch from 780f4ce to ae1e084 Compare May 15, 2025 16:27
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-load-Jacobian branch from ae1e084 to 204a514 Compare May 15, 2025 16:29
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed!

@nkoukpaizan
Copy link
Collaborator Author

  • Spack Ubunutu x86_64 Buildcache / Build gridkit with Spack (16, gridkit@develop +enzyme ^enzyme@0.0.173) (pull_request)

Waiting for CI. I mistakenly pushed a Spack update I had locally. Let's see if I can revert it.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-load-Jacobian branch from 4107910 to 35ea975 Compare May 15, 2025 17:01
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-load-Jacobian branch from 4f008ef to 4fa61cf Compare May 15, 2025 17:42
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-load-Jacobian branch from 798e302 to dbabcf8 Compare May 15, 2025 18:34
@nkoukpaizan nkoukpaizan merged commit 516cb89 into develop May 15, 2025
3 checks passed
@pelesh pelesh deleted the nicholson/fix-load-Jacobian branch June 10, 2025 18:02
WiktoriaZielinskaORNL pushed a commit that referenced this pull request Jul 23, 2025
* Fix load Jacobian.

* Upgrade base image id to build a new cache.

* Spack concretizer unify.

* Rename GH CI test.

* Create new local-buildcache and push to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing issue: Unit test for PhasorDynamics/Load model Jacobian fails

3 participants