Default is to build GridKit without dependencies #186
Conversation
pelesh
added
development
lukelowry
left a comment
lukelowry
left a comment
There was a problem hiding this comment.
I agree with need of this PR. One minor issue, details below. Otherwise, builds correctly and all tests passed.
| @@ -1,5 +1,5 @@ | |||
| add_executable(test_case_format runCaseFormatTests.cpp) | |||
| target_include_directories(test_case_format PRIVATE ${THIRD_PARTY_DIR}/nlohmann-json/single_include ${THIRD_PARTY_DIR}/magic-enum/include) | |||
| target_include_directories(test_case_format PRIVATE ${GRIDKIT_THIRD_PARTY_DIR}/nlohmann-json/single_include ${GRIDKIT_THIRD_PARTY_DIR}/magic-enum/include) | |||
There was a problem hiding this comment.
I had to comment out this file for my machine to build. No issues with the json include, but compiler was unable to locate <magic_enum/magic_enum.hpp>. Could be something on my end, but unclear how to fix.
There was a problem hiding this comment.
Can you try git submodule update --init?
There was a problem hiding this comment.
Forgot to thank you for this fix. This was the issue. Is it possible to add this advice to the main README or perhaps a debug page for GridKit? @nkoukpaizan @pelesh
|
It would be good to add GRIDKIT_ENABLE_ENZYME/GRIDKIT_USE_ENZYME to And I understand why the other options are there (e.g., |
Addressed in e0e25a7. |
* Using SUNDIALS is off by default * Make SUNDIALS and KLU optional. * KLU is not a direct dependency anymore
Description
Default GridKit build was with SUNDIALS as dependency. This PR changes that to a build with no dependencies. This can help, for example, work on component models and unit tests, which do not require a solver enabled.
Proposed changes
Made changes to CMake so that GridKit modules and examples are built only if their required dependencies are enabled.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments