Skip to content

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Aug 18, 2025

Description

Upgrading to upstream Spack v1.0.1 and using a Spack repo for the yet-to-be-pushed-upstream GridKit package. As of Spack v1.0, the core library (https://github.com/spack/spack) is separate from the packages (https://github.com/spack/spack-packages), which simplifies the use of a local repo to keep changes that we need.

Closes #77
Closes #187

Proposed changes

  • Buildsystem-only changes.
  • Pointing to upstream spack instead of my fork
  • Local Spack repo to maintain the GridKit package. We will need to contribute this upstream eventually.
  • Updated CI accordingly

Checklist

  • All tests pass.
  • [N/A] Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Aug 18, 2025
@nkoukpaizan nkoukpaizan requested a review from pelesh August 18, 2025 18:23
@nkoukpaizan nkoukpaizan marked this pull request as ready for review August 19, 2025 12:48
Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some semantic changes.

@shakedregev shakedregev merged commit b5a54ff into develop Aug 19, 2025
4 checks passed
@shakedregev shakedregev deleted the nicholson/spack-v1.0 branch August 19, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Spack package to build GridKit without dependencies by default Figure out how to use Spack v1.0.0

3 participants