Forward compatibility with SUNDIALS #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Tested and seems to work. I suggest adding the constraint for sundials>7.x to the CMakeLists.txt as done here. The current implementation is asking for 6.0.0, and that's not being enforced. |
Collaborator
Author
Good catch, thanks! Fixed in 7920475 and tested. |
nkoukpaizan
approved these changes
Dec 10, 2024
Collaborator
|
A bit late to the party, but I can also confirm that I can compile and run examples with Sundials >= 7.0.0 |
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Modify Ida and Kinsol classes to build with SUNDIALS >= 7. * Update README. * Use SUNDIALS null communicator. * Update CMakeLists.txt to explicitly require sundials >= 7.x (no going back)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure GridKit is forward compatible with SUNDIALS, meaning it will require SUNDIALS version >= 7.0. There is no need in supporting older SUNDIALS versions in GridKit.