Skip to content

Conversation

@pelesh
Copy link
Collaborator

@pelesh pelesh commented Jan 21, 2025

Reorganize directory structure of GridKit per draft proposed in #43.

Closes #43

@pelesh pelesh self-assigned this Jan 21, 2025
@pelesh
Copy link
Collaborator Author

pelesh commented Jan 21, 2025

140 files changed looks intimidating but most of it is moving files with minimal changes to subdirectories.

@pelesh pelesh marked this pull request as draft January 21, 2025 23:20
@pelesh pelesh marked this pull request as ready for review January 21, 2025 23:21
Copy link
Collaborator

@abirchfield abirchfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structuring looks good to me.

@nkoukpaizan
Copy link
Collaborator

The move of source files to src looks good to me.

As far as I can tell, only src and model currently have lowercase capitalization. It looks odd when it's just those two, so maybe keep Src and Model for now and plan for a "better", consistent capitalization scheme later?

@pelesh pelesh merged commit 129cac4 into develop Jan 22, 2025
2 checks passed
@pelesh pelesh deleted the reorg-dev branch March 14, 2025 03:35
pelesh added a commit that referenced this pull request Apr 14, 2025
* Move sources to src/ dir

* Rename ComponentLib to Model.

* Change dir name SparseMatrix -> LinearAlgebra.

* Rename Documentation -> docs.

* Renamed Examples -> examples.

* Rename CMake -> cmake

* Rename Buildsystem -> buildsystem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize files and directories

4 participants