Add GENROUwS model for a synchronous machine #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
abirchfield
approved these changes
Apr 7, 2025
Collaborator
abirchfield
left a comment
abirchfield
left a comment
There was a problem hiding this comment.
Looks good. Some of the comments on GENROU haven't been updated from branch but those can be quickly fixed.
reid-g
approved these changes
Apr 7, 2025
Collaborator
reid-g
left a comment
reid-g
left a comment
There was a problem hiding this comment.
Looks good to me.
Error in the example seems higher then expected since default reltol = 1e-7. However, this seems due to how discontinuities are handled though.
alexander-novo
approved these changes
Apr 7, 2025
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Genrou model implemented * Example to verify correctness and compare results to Powerworld. * Placeholder for unit tests. --------- Co-authored-by: abirchfield <adam.b.birchfield@gmail.com> Co-authored-by: pelesh <pelesh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GENROUwS model for the synchronous machine and a 2-bus example with the generator connected to an infinite bus by a transmission line. The example checks its results against Powerworld and runs on the CI pipeline. This provides some basic verification of the model.
Cloases #65.
What is outside the scope of this PR:
PhasorDynamics::Genroumodel. See Create initial unit test forPhasorDynamics::Genroumodel #78PhasorDynamics::Genroudocumentation. See DocumentPhasorDynamics::Genroumodel #79