Lukel/phasor docs #88
Conversation
abirchfield
left a comment
abirchfield
left a comment
There was a problem hiding this comment.
Overall looks good. Need to make most of the changes Slaven suggested and one other about the saturation.
Co-authored-by: pelesh <peless@ornl.gov>
|
Branch is up to date with requested edits. Thank you for the feedback! We can extend explanations further, just please identify what could benefit from enrichment. |
|
Move 4 differential variables back to differential as discussed |
Correction is needed for both, GENROU and GENSAL docs. |
|
Okay, ready for approval. I will create new branch for exciter & governor models moving forward and use these models as reference for formatting. |
abdourahmanbarry
left a comment
abdourahmanbarry
left a comment
There was a problem hiding this comment.
Looks very good, Luke. I have identified three typos to be fixed.
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Please check highlighted sign issues.
Co-authored-by: pelesh <peless@ornl.gov>
Co-authored-by: pelesh <peless@ornl.gov>
|
Changes applied, thank you. |
Description
The documentation for the GENROU and GENSAL (Synchronous Machine models) has been reviewed and modified to be consistent with the implementation.
This closes issue #79
Proposed changes
The README equations and nomenclature notation is derived directly from the C++ implementation. Information from the general Synchronous Machine README has been removed and put into the relevant sub-models. Since we will be implementing other classes of synch. generator models, so the GENROU and GENSAL equations should not be inn the folders general README.
Further comments
Let me know if there was any notation violations, the guidelines don't seem to have much in regards to math notation.