Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor Core enabled for mixed precision on GPUs that allow it #206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Dec 13, 2023

No description provided.

@allaffa allaffa added the enhancement New feature or request label Dec 13, 2023
@allaffa allaffa requested a review from jychoi-hpc December 13, 2023 02:26
@allaffa allaffa self-assigned this Dec 13, 2023
@jychoi-hpc
Copy link
Member

I ran a few test runs using qm9 on Frontier. I found the following related to this AMP feature (Automatic Mixed Precision):

  • (Almost) no speed up in time: it may differ by cases but at least in the qm9 case the wallclock time reduction was very very small.
  • But, memory saving was obvious: 114 MB with AMP vs 180 MB without AMP
  • Numeric artifacts can occur with AMP. I.e., we don't get same numbers with AMP and without AMP. Here are the loss plots:
    image

@jychoi-hpc
Copy link
Member

We may need to make this feature optional as it changes the accuracy or losses.

@allaffa
Copy link
Collaborator Author

allaffa commented Dec 18, 2023

We may need to make this feature optional as it changes the accuracy or losses.

@jychoi-hpc I agree. The differences between full precision and mixed-precision seem to be drastic, even for a relatively simple dataset like QM9

@allaffa allaffa mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants