-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PNAPlus Stack #267
Adding PNAPlus Stack #267
Conversation
Note: I changed the MAE threshold for MFC because it was failing with 0.2571 > 0.2 ,and assumed this was cause by just higher losses rather than a structural error. |
It looks good to me. @allaffa and @pzhanggit how do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @pzhanggit what do you think?
@pzhanggit Is this good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I just have one comment. Sorry I somehow missed it
Adding PNAPlus Stack
This PR adds the PNAPlus stack I've recently created and experimented with. It replicates DimeNet's use of Bessel Functions and Element-Wise product of "message_ij" in its message propagation. In my intuition, and according to some small experiments, this is more effective than raw concatenation as can be done with edge features. Otherwise, this operates the same as regular PNA.
This is an Invariant Stack.