Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed adios2 dataset class import in examples #290

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fixed adios2 dataset class import in examples #290

merged 1 commit into from
Oct 4, 2024

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Oct 3, 2024

@AdithyaRaman
Would you mind quickly reviewing this PR so that I can quickly merge it and fix the imports of ADIOS2 in the examples?

@allaffa allaffa added the bug Something isn't working label Oct 3, 2024
@allaffa allaffa requested a review from AdithyaRaman October 3, 2024 16:40
@allaffa allaffa self-assigned this Oct 3, 2024
@allaffa allaffa mentioned this pull request Oct 3, 2024
Merged
AdithyaRaman
AdithyaRaman approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@AdithyaRaman AdithyaRaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. I have pulled the repo with changes and verified correctness by running it on Frontier

@allaffa allaffa merged commit 9f3b0fb into ORNL:main Oct 4, 2024
2 checks passed
@allaffa allaffa deleted the fix_adios2class_import branch October 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdithyaRaman AdithyaRaman AdithyaRaman approved these changes

Assignees

@allaffa allaffa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allaffa @AdithyaRaman