Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omat24 example #295

Merged
merged 11 commits into from
Nov 9, 2024
Merged

omat24 example #295

merged 11 commits into from
Nov 9, 2024

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Oct 21, 2024

@ArCho48 @RylieWeaver
I would like for you to take a look at how the code is structured, so that you can start getting acquainted with how we import new datasets in HydraGNN.

@allaffa allaffa added the enhancement New feature or request label Oct 21, 2024
@allaffa allaffa self-assigned this Oct 21, 2024
@RylieWeaver
Copy link
Collaborator

@allaffa

Thank you for pointing it out. I will put down my main findings to clarify if I'm understanding things correctly.

Overall, we now support download links and use a FAIRChem class to parse the molecular objects in new datasets.
(1) Download links are defined inside lists and downloaded in a loop based on the task (train/val)
(2) We use the AseDBDataset, which gives us functions to easily get traits such as atomic number, position, energy, forces, etc...

examples/omat24/train.py Outdated Show resolved Hide resolved
@allaffa allaffa requested a review from jychoi-hpc November 8, 2024 17:44
@allaffa
Copy link
Collaborator Author

allaffa commented Nov 8, 2024

@jychoi-hpc
Thank you for your review. I addressed the issue of type

Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just finished testing. I was able to generate the adios file and run training. The code looks good. Thank you for the update.

@allaffa allaffa merged commit ca29030 into ORNL:main Nov 9, 2024
2 checks passed
@allaffa allaffa deleted the omat24 branch November 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants