Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the issue related to generating conv_args that are in-line with periodic boundary conditions.
The following implementation should be robust under the following assumptions, which I think should always be true:
(1) radius < min(supercell_size) / 2
(2) The edge_index has been generated correctly with periodic boundary conditions
(3) data.supercell_size exists if and only if pbc conditions are used
Currently, only two models are updated to use the new functionality. If this is a good solution, it can be easily extended to the others.