Fix pbc conv args (secondary method to compare) (draft) #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for a different method to properly get vectors and differences with pbc conditions.
Main Takeaways:
(1) There is a way to pass the different dimensions for pbc as a list, such as
[True, False, True](2) ASE is able to pass pbc-consistent edge vectors easily, without us having to worry about the details.
Questions/Problems:
(1) Is it a requirement of HYDRA that we pass the data through the radius_graph? If not, this would be a problem, because the
edge_vecwill not be created and will be missing when called by a model stack.