Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion warning #60

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Fix assertion warning #60

merged 2 commits into from
Dec 9, 2021

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Dec 9, 2021

Used this assertion warning introduced in #45 to test and make sure that we can treat warnings as errors in the CI. This should now help keep the code warning free

Ignore deprecation warnings from tpl
@streeve streeve requested review from allaffa and pzhanggit December 9, 2021 18:26
@streeve streeve self-assigned this Dec 9, 2021
@allaffa allaffa merged commit 44ebe47 into ORNL:main Dec 9, 2021
@streeve streeve deleted the fixup_unscale_assert branch December 9, 2021 19:40
RylieWeaver pushed a commit to RylieWeaver/HydraGNN that referenced this pull request Oct 17, 2024
* Treat warnings as errors;
Ignore deprecation warnings from tpl

* fixup unscale assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants