Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data to the device once #61

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Move data to the device once #61

merged 2 commits into from
Dec 15, 2021

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Dec 9, 2021

NEEDS TO BE TESTED ON THE DEVICE. But I'm pretty sure it works. I don't think this affects performance, just cleans up the code

  • Move data to the device on loading, rather than every step.
  • Splits device name and device functions since we usually only want one or the other

@streeve streeve requested review from allaffa and pzhanggit December 9, 2021 19:00
@streeve streeve self-assigned this Dec 9, 2021
@allaffa allaffa merged commit ee315b5 into ORNL:main Dec 15, 2021
allaffa added a commit that referenced this pull request Dec 15, 2021
@streeve streeve deleted the device_data branch March 9, 2022 14:48
RylieWeaver pushed a commit to RylieWeaver/HydraGNN that referenced this pull request Oct 17, 2024
* Split device and device_name functions

* Move data to device in loading rather than training (does NOT affect performance)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants