added dashed red diagonal on scatterplot #63
Conversation
allaffa
force-pushed
the
diagonal_dashed_line_scatterplot
branch
2 times, most recently
from
a4e23e5 to
c071152
Compare
allaffa
force-pushed
the
diagonal_dashed_line_scatterplot
branch
from
c4e60fc to
24595af
Compare
| def add_identity(self, axes, *line_args, **line_kwargs): | ||
| (identity,) = axes.plot([], [], *line_args, **line_kwargs) | ||
|
|
||
| def callback(axes): |
There was a problem hiding this comment.
Not sure I understand why the callback is needed
There was a problem hiding this comment.
The call back function keeps track of potential future changes in the axis format, and calls back this function to re-run and ensure that the red line is reformatting according to the new display.
For instance, if you later change the range of the axis, you want to make sure that the red line extends or contract based on the new axis limit. Instead of doing that manually, the callbacks performs the re-adjustment automatically.
There was a problem hiding this comment.
Makes sense. I tried it out - very fancy. I'll open an issue to make sure you can actually interact with plots rather than only save them
| @@ -550,6 +553,21 @@ def create_scatter_plot_nodes_vec( | |||
| fig.savefig(f"./logs/{self.model_with_config_name}/" + varname + ".png") | |||
| plt.close() | |||
|
|
|||
| def add_identity(self, axes, *line_args, **line_kwargs): | |||
There was a problem hiding this comment.
Is it bad to just plot a line y=x? I'm not familiar with the approach here
There was a problem hiding this comment.
This does indeed y=x. But you need to make sure that the y=x is extended through the entire range of the plot frame.
| @@ -124,6 +125,8 @@ def __scatter_impl( | |||
| ax.set_xlim(minimum, maximum) | |||
| ax.set_ylim(minimum, maximum) | |||
|
|
|||
| self.add_identity(ax, color="r", ls="--") | |||
There was a problem hiding this comment.
Move this inside if xylim_equal:?
There was a problem hiding this comment.
No, I think we want this regardless of forcing x_lim = y_lim
* added dashed red diagonal and use of empty dots in scatterplot * formatting fixed Co-authored-by: Massimiliano Lupo Pasini <7ml@ornl.gov>
Also makes scatter plot empty markers