-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ising model #87
Merged
Merged
Ising model #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
reviewed
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I was also able to start testing locally
streeve
approved these changes
Jan 13, 2022
pzhanggit
reviewed
Jan 13, 2022
@pzhanggit it does make sense, but I would like to give the idea that the Ising model naturally flows into the FePt case without changing of predictive tasks. |
RylieWeaver
pushed a commit
to RylieWeaver/HydraGNN
that referenced
this pull request
Oct 17, 2024
* reformatting * Update create_configurations.py * json file added for Ising model * Update ising_model.json * change in the definition of the spin and change of data format in .json file * requirements file for example added * Rename ising data * Add tqdm * Rename spin and redefine atom_type * removed subtraction of -1 from coordinates * sine used to map atom features into spin * sinusoidal spin used to calculate the energy * setting for creation of dfataset and model changed Co-authored-by: Massimiliano Lupo Pasini <7ml@ornl.gov> Co-authored-by: Sam Reeve <6740307+streeve@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.