Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack package implementation with Ascent rebuild pipeline #10

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

cameronrutherford
Copy link
Collaborator

@cameronrutherford cameronrutherford commented Oct 17, 2023

Need to make sure that Ascent rebuild can push to GitHub, and then this is good to go! See Spack PR here: spack/spack#40149

@cameronrutherford
Copy link
Collaborator Author

LGTM @pelesh and @ryandanehy I think this is ready

@cameronrutherford
Copy link
Collaborator Author

I still didn't update docs like I said I would, so perhaps we just make another issue so I get back to that... this is basically the same as ExaGO scripts so I would just be re-typing what's mostly in there with a few modifications

@pelesh
Copy link
Collaborator

pelesh commented Oct 17, 2023

I still didn't update docs like I said I would, so perhaps we just make another issue so I get back to that... this is basically the same as ExaGO scripts so I would just be re-typing what's mostly in there with a few modifications

More documentation would be helpful, especially for Spack related issues, but I agree, we need a first stab at this in the main development branch.

@pelesh pelesh merged commit 0213d6e into develop Oct 17, 2023
2 checks passed
@pelesh pelesh mentioned this pull request Oct 17, 2023
17 tasks
@cameronrutherford
Copy link
Collaborator Author

cameronrutherford commented Oct 18, 2023

@ryandanehy feature or bug, the commit that's automated runs all testing again. We can change that by adding [ascent-test], but I would love to find a way to skip GitHub actions with different rules based on strings in commit messages, but am yet to bother. Especially applies with ExaGO and other repos where GitHub actions can be longer running builds.

@pelesh pelesh deleted the spack-package-dev branch December 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants