-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of #150 #151
Draft
superwhiskers
wants to merge
4
commits into
develop
Choose a base branch
from
implement-initial-suggestions-from-150
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop dead code within `CMakeLists.txt` - remove old `.github/workflows/.clang-format` - create new `.clang-format` at the repository root, with settings based on observed patterns & `CONTRIBUTING.md`
superwhiskers
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
question
Further information is requested
labels
Jun 3, 2024
…format 16 minimum
cameronrutherford
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but I approve.
I am not a regex expert so I did not have a chance to verify that those are correct.
Before it is ready for merge, we need to test it on a few representative code snippets to make sure there are no unintended artifacts. |
pelesh
reviewed
Jun 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
question
Further information is requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request implements the initial suggestions proposed within #150
i'm not going to merge this until some discussion about the formatting options in
.clang-format
has happened, and appropriate modifications have been made toCONTRIBUTING.md