Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated code and consolidate coo2csr functionality in a single function. #173

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Jun 25, 2024

Consolidate coo2csr functions in MatrixHandler and Csr classes into a single standalone function in matrix namespace. This utility function is now called by both, MatrixHandler and Csr classes.

This is first step before refactoring coo2csr function, as well as matrix::Sparse class to address #166.

@pelesh pelesh added the enhancement New feature or request label Jun 25, 2024
@pelesh pelesh self-assigned this Jun 25, 2024
@superwhiskers
Copy link
Collaborator

without suggesting any additional modifications to the code, i ask that you move the utilities.cpp & utilities.hpp files to Utilities.cpp and Utilities.hpp, as in #164.

@pelesh pelesh marked this pull request as ready for review July 2, 2024 18:27
@pelesh pelesh merged commit f4b7f88 into develop Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants