Add functionality test for LUSOL #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonecoldhughes
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Overall, this file is structured very clearly. Separating the code into more functions, incorporating data files without hardcoded paths, avoiding manual memory management with new/delete, and adding some more high level comments that provide more insight into exactly what is going on with the validation sections would improve it. I selected the "Submit feedback that must be addressed before merging." option before submitting this review: if you prefer, I can instead select "Submit general feedback without explicit approval" in future reviews.
stonecoldhughes
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is based on KLU functionality test but because LUSOL does not have refactorization option, the test simply performs two full factorizations for different matrices.
This is based on @superwhiskers test in #164.
Resolves #158.