Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter setting for direct solvers #215

Merged
merged 13 commits into from
Jan 24, 2025
Merged

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Jan 23, 2025

Implement generic functions for setting direct solvers configuration parameters. The parameters are expected to come from command line input.

Several compiler warnings are fixed here, as well.

Closes #96

@pelesh pelesh added the enhancement New feature or request label Jan 23, 2025
@pelesh pelesh self-assigned this Jan 23, 2025
resolve/LinSolver.hpp Outdated Show resolved Hide resolved
@pelesh pelesh requested a review from shakedregev January 24, 2025 01:37
resolve/LinSolverDirectRocSolverRf.cpp Outdated Show resolved Hide resolved
resolve/LinSolverDirectCpuILU0.cpp Show resolved Hide resolved
resolve/LinSolverDirectCpuILU0.cpp Show resolved Hide resolved
resolve/LinSolverDirectCuSolverGLU.cpp Show resolved Hide resolved
resolve/LinSolverDirectCuSolverRf.cpp Show resolved Hide resolved
resolve/LinSolverDirectKLU.cpp Show resolved Hide resolved
resolve/LinSolverDirectLUSOL.cpp Show resolved Hide resolved
resolve/LinSolverDirectRocSolverRf.cpp Show resolved Hide resolved
resolve/LinSolverDirectRocSparseILU0.cpp Show resolved Hide resolved
resolve/LinSolverDirectSerialILU0.cpp Show resolved Hide resolved
Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changes

@pelesh pelesh merged commit 53eb251 into develop Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comprehensive way to manage ReSolve configuration parameters
2 participants