-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doxygen #44
Doxygen #44
Conversation
390ee4c
to
a3ed85e
Compare
f01a604
to
ed9f367
Compare
Documentation lives here https://ornl.github.io/ReSolve/ To see the doxygen based documentation check out the source documentation page. These docs will be built on every pr automatically so that contributors can see their additions. Options to futher explore: PS: This is made via github action I created here: https://github.com/ryandanehy/sphinx-doxygen Therefore it should be incredibly easy to apply this method of documentation to other repos. |
@ryandanehy, this is great! A couple of suggestions:
Other than these minor issues, this looks very good. |
Also, to add to the list above, Doxygen needs to be built with graphviz support, so it can draw UML diagrams. |
@ryandanehy, it seems that as we are providing Doxygen input file template, we are overriding Doxygen options set in CMake. I'll take a look. Ideally, all of our preferred options should be in the input file template. That will make CMake config cleaner, as well. |
c418c62
to
2bb7286
Compare
@pelesh I think I made the changes you requested. Lmk what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor changes to make, most importantly Doxygen options selected in the CMake file should be placed in the Doxyfile.in
as my understanding is it is used to generate Doxygen docs (at least based on conf.py
file.
Also, in the Doxygen docs, UML files are not generated or at least I don't see them.
d7dc0a6
to
98ff352
Compare
@pelesh is this what you were going for? |
Looks much better!! |
1bd65d1
to
c6d399a
Compare
@ryandanehy, let me please review once more. There are a few things such as copyright statement that needs to be fixed, but all the main features are in the PR and working. Thanks for the great work and figuring out all pathing nightmares ;). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first attempt at getting documentation for ReSolve. There are several minor issues that are best addressed through separate PR(s).
No description provided.