Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen #44

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Doxygen #44

merged 2 commits into from
Nov 23, 2023

Conversation

jaelynlitz
Copy link
Collaborator

No description provided.

@jaelynlitz jaelynlitz marked this pull request as draft October 31, 2023 18:43
@ryandanehy ryandanehy force-pushed the documentation-doxy branch 3 times, most recently from 390ee4c to a3ed85e Compare November 7, 2023 22:17
@pelesh pelesh added the documentation Improvements or additions to documentation label Nov 11, 2023
@pelesh pelesh added this to the First Release milestone Nov 11, 2023
@ryandanehy ryandanehy force-pushed the documentation-doxy branch 2 times, most recently from f01a604 to ed9f367 Compare November 17, 2023 20:52
@ryandanehy
Copy link
Collaborator

ryandanehy commented Nov 17, 2023

Documentation lives here https://ornl.github.io/ReSolve/

To see the doxygen based documentation check out the source documentation page.

These docs will be built on every pr automatically so that contributors can see their additions.

Options to futher explore:
Direct links to certain doxygen pages on the main read the docs page.
More page and content to add.

PS: This is made via github action I created here: https://github.com/ryandanehy/sphinx-doxygen Therefore it should be incredibly easy to apply this method of documentation to other repos.

@ryandanehy ryandanehy marked this pull request as ready for review November 20, 2023 19:01
@ryandanehy ryandanehy changed the title Draft: Doxygen Doxygen Nov 20, 2023
@ryandanehy
Copy link
Collaborator

@pelesh

@pelesh
Copy link
Collaborator

pelesh commented Nov 20, 2023

@ryandanehy, this is great! A couple of suggestions:

  • Provide links to readthedocs at main README file.
  • Similarly to doxygen API docs.
  • For some reason, doxygen docs are not built with doxygen awesome stylesheets. Could we fix that.

Other than these minor issues, this looks very good.

@pelesh
Copy link
Collaborator

pelesh commented Nov 20, 2023

Also, to add to the list above, Doxygen needs to be built with graphviz support, so it can draw UML diagrams.

@pelesh
Copy link
Collaborator

pelesh commented Nov 20, 2023

@ryandanehy, it seems that as we are providing Doxygen input file template, we are overriding Doxygen options set in CMake. I'll take a look. Ideally, all of our preferred options should be in the input file template. That will make CMake config cleaner, as well.

@ryandanehy
Copy link
Collaborator

ryandanehy commented Nov 21, 2023

@pelesh I think I made the changes you requested. Lmk what you think.
Documentation lives here https://ornl.github.io/ReSolve/

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor changes to make, most importantly Doxygen options selected in the CMake file should be placed in the Doxyfile.in as my understanding is it is used to generate Doxygen docs (at least based on conf.py file.

Also, in the Doxygen docs, UML files are not generated or at least I don't see them.

CMakeLists.txt Show resolved Hide resolved
cmake/ReSolveAddLibrary.cmake Outdated Show resolved Hide resolved
resolve/matrix/Csr.cpp Outdated Show resolved Hide resolved
resolve/matrix/Sparse.cpp Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@ryandanehy
Copy link
Collaborator

@pelesh is this what you were going for?
https://ornl.github.io/ReSolve/doxygen/html/dir_5136c54ba47d989d05eb394194374e6c.html

@cameronrutherford
Copy link
Collaborator

@pelesh is this what you were going for?

https://ornl.github.io/ReSolve/doxygen/html/dir_5136c54ba47d989d05eb394194374e6c.html

Looks much better!!

@pelesh
Copy link
Collaborator

pelesh commented Nov 23, 2023

@ryandanehy, let me please review once more. There are a few things such as copyright statement that needs to be fixed, but all the main features are in the PR and working. Thanks for the great work and figuring out all pathing nightmares ;).

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first attempt at getting documentation for ReSolve. There are several minor issues that are best addressed through separate PR(s).

docs/doxygen/Doxyfile.in Show resolved Hide resolved
docs/doxygen/index.rst Show resolved Hide resolved
docs/sphinx/Makefile Show resolved Hide resolved
docs/sphinx/coding_guide/index.md Show resolved Hide resolved
docs/sphinx/licenses.md Show resolved Hide resolved
@pelesh pelesh merged commit e877a97 into develop Nov 23, 2023
6 of 7 checks passed
@ryandanehy ryandanehy deleted the documentation-doxy branch November 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants