-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No 4K Compatibility #30
Comments
Hi @MNLierman, As you noticed, the API is indeed limited to 1080p. For now, I don't have information about newer 4K API that may be present on Windows 11, so I cannot implement it. If you find information about it, do not hesitate to share as implementing it should be fairly straightforward if it's similar to the existing one.
Where to begin: We would need documentation about the newer APIs so we can implement them. |
Windows 10 uses Spotlight API v3 (1080p) Windows 11 uses Spotlight API v4 (4K) Investigate Windows 11 and find new endpoint Document new API endpoint in SpotlightAPI.md Add support for new API version in Spotlight Downloader Add --api-version command-line switch to select version Make APIv4 the default version, use --api-version 3 for APIv3
I'm happy to let you know that after digging around, I found the new API endpoint for 4K images and implemented it in SpotlightDownloader v1.5.0. I took this opportunity to adjust the caption feature to upscale the image before adding text in case the image is smaller than your screen, so that even 1080p images should have a sharp caption on your 4K display. Let me know if you are still facing any issue with Spotlight Downloader. |
Issue:
This script doesn't appear to support 4K resolution, despite the max res parameter.
Abstract:
4K screens have become predominately mainstream as manufacturing costs for 4K displays have significantly dropped, and 4K screens are more accessible at more reasonable prices that fit the budget of a broader range of people. More and more people are adapting 4K displays, including myself. This raises an important issue which is instantly obvious, this script seems to only download 1080p resolution. On my Samsung 4K monitors, the images appear pixelated and blurry. This problem is not related to compression or the lockscreen settings but rather the resolution of the images downloaded from the API, which are only 1080p. I appreciate this script for what it does, especially the random selection of a lockscreen image, giving a unique look when powering on your computer. Microsoft's lack of customization options for the lockscreen, the forced advertising, and inability to fine tune your lockscreen options, is frustrating to say the least. Thus, I find value in this project, and aim to understand why this script only supports 1080p. I will be exploring and researching this issue, and I may be seeking assistance in implementing a fix.
Details:
Questions:
These are questions I am looking to understand during my research on this issue.
Where To Begin:
I have a good understanding of C#, but my knowledge of APIs, JSON, and web applications is limited. Therefore, I might struggle to implement a fix for this issue on my own. I will be conducting research to understand this a little deeper, but it would be nice to know how much anyone, or @ORelio knows about this API and any ideas for implementing a fix for this. I wasn't really wanting to abandon the script, unless someone else has created a better version already.
Thank you for your time and assistance.
The text was updated successfully, but these errors were encountered: