1062: Encryption tweaks #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
feature/encryption-tweaks
branch
from
4d27bcd
to
717899b
Compare
cableman
requested changes
Jun 25, 2024
| * @see Drupal\webform_encrypt\WebformEncryptSubmissionStorage::loadData | ||
| * @see Drupal\webform\WebformSubmissionStorage::loadData | ||
| */ | ||
| protected function loadData(array &$webform_submissions) { |
There was a problem hiding this comment.
Yes, WebformEncryptSubmissionStorage::loadData calls WebformSubmissionStorage::loadData before decrypting resulting in computed elements being computed before having their values decrypted.
In our case this result in the classic TypeError: Unsupported operand types: string * int in __TwigTemplate__.
|
Maybe even more documentation on the storage class, why all this is needed. |
Added extra section to class documentation. |
cableman
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/tickets/showKanban?tab=ticketdetails#/tickets/showTicket/1062