1062: Force encryption on all elements #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cableman
requested changes
Jun 28, 2024
| public function formAlter(array &$form, FormStateInterface $form_state, string $form_id) { | ||
| if ('webform_ui_element_form' === $form_id) { | ||
| if (isset($form['element_encrypt'])) { | ||
| unset($form['element_encrypt']); |
There was a problem hiding this comment.
Would it be better to set access = false
There was a problem hiding this comment.
With the current preSave hook ensuring encryption on all elements are enabled, the end behaviour would be the same.
Maybe from an understanding point of view using access = false makes more sense? I'm not sure.
There was a problem hiding this comment.
To avoid potential issues with other parts of code accessing this element_encryption we will use access = false.
cableman
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/tickets/showKanban?tab=ticketdetails#/tickets/showTicket/1062