Digital post #62
Merged
Digital post #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/digital-post
branch
3 times, most recently
from
d3a460a
to
8602f1e
Compare
rimi-itk
force-pushed
the
feature/digital-post
branch
10 times, most recently
from
7359846
to
950f87a
Compare
rimi-itk
force-pushed
the
feature/digital-post
branch
from
950f87a
to
7305397
Compare
rimi-itk
force-pushed
the
feature/digital-post
branch
from
b3e3340
to
14d90c2
Compare
stankut
approved these changes
Oct 9, 2023
modules/os2forms_digital_post/src/Helper/BeskedfordelerHelper.php
Outdated
Show resolved
Hide resolved
rimi-itk
force-pushed
the
feature/digital-post
branch
from
29eae58
to
a69ce5a
Compare
|
@stanbellcom, I've cleaned up and added some comments in the code. Thanks for useful feedback. |
stankut
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Digital post (
os2forms_digital_post) module (cf. modules/os2forms_digital_post/README.md).This is a follow-up to #56 where we had some workarounds to handle the case when
os2forms_digital_postwas not installed or available.Note: The digital post module have two dependencies† that currently live in the
itk-devvendor namespace and to people in the know this may seem a bit odd. These dependencies, however, make sense outside OS2Forms and are therefore not moved into https://github.com/OS2Forms/os2forms. It would make sense to move them to a general OS2 organization, e.g. https://github.com/os2web, say, but we don't yet know how to actually handle this (it's a question of resources; finances, responsibility, governance etc.).Another note: Our/Drupal's coding standards do not require
@paramannotations on all function parameters and therefore these are not added on all functions, but only where they add real value.† a Drupal module: https://github.com/itk-dev/beskedfordeler-drupal and a library: https://github.com/itk-dev/serviceplatformen