-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kubernetes #64
Conversation
Let's simplify the whole "data options for cluster" to just be kubernetes. If a module/option exists on both pizer & owens we'll support it in kubernetes - otherwise we won't. I'll bring this up in our classroom meetings and we'll either support this scheme or backport the modules to owens. |
I made it so the only RStudio Server versions available for |
Should I go ahead and add |
Yea that'll be fine. |
Updated with commits so should still work on dev and test instances of our ondemand servers. |
Testing in test , I missed a few places in Javascript to handle test/dev names. |
Fix test/dev case to also work, just had to update form fields to account for the 2 non-production Kubernetes cluster names. |
form.yml.erb
Outdated
@@ -135,52 +197,82 @@ attributes: | |||
- [ | |||
"4.0.2", "app_rstudio_server/4.0.2", | |||
data-option-for-owens: true, | |||
data-option-for-pitzer: true | |||
data-option-for-pitzer: true, | |||
data-option-for-kubernetes: true,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these extra commas are throwing the yaml parsing off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed, was likely existing trailing comma and I was copy+paste the items and must have missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go.
No description provided.