Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure core count behavior works with Kubernetes #66

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Jul 9, 2021

Fixes #65

Because I removed logic to look at cluster + node type, we either have to do the lowest possible cluster (owens) or just set on some low value. I opted to just max out core count for Kubernetes at 10, but can easily adjust to max the max the max for smallest nodes which are Owens.

@treydock treydock requested a review from johrstrom July 9, 2021 18:05
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@johrstrom johrstrom merged commit 52e363f into master Jul 9, 2021
@johrstrom johrstrom deleted the kubernetes branch July 9, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing to k8s cluster sets cores to empty
2 participants