Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3391 emphasize template select #3863

Merged
merged 9 commits into from
Oct 14, 2024
Merged

3391 emphasize template select #3863

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6693072
Revert project-card styling changes. Make Template select label more …
euler-room Oct 9, 2024
9a46e90
Merge branch 'master' into 3391-emphasize-template-select
euler-room Oct 9, 2024
380861a
Adjusts the size of the card-header.
euler-room Oct 9, 2024
19e6412
Hide form/disable save until template is selected
euler-room Oct 11, 2024
6210179
Require template for form submission.
euler-room Oct 11, 2024
c536655
Remove blank default value in projects_contoller#templates
euler-room Oct 11, 2024
6f3b261
Render template select only when 'create new project from template' i…
euler-room Oct 11, 2024
bfba5da
Remove superfluous variable
euler-room Oct 11, 2024
463e49b
Remove superfluous ids.
euler-room Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions apps/dashboard/app/controllers/projects_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,8 @@ def templates
[label, project.directory, data]
end

if templates.size.positive?
templates.prepend(['', '', { 'data-description': '', 'data-icon': '' }])
else
[]
end
return templates if templates.size.positive?
return []
end

def project_params
Expand Down
7 changes: 3 additions & 4 deletions apps/dashboard/app/views/projects/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
%>

<div class='card'>
<h2 class='card-header'>Project Details</h2>
<%= render(partial: "template_select", locals: { form: form, templates: @templates}) %>
<div id='project_form'>
<div class='card-header'>
<%= form.select(:template, @templates, { prompt: "--- select template ---" }, required: true, label_class: "h4")%>
</div>
<div class='card-group'>
<div class='card'>
<div class='card-body'>
Expand Down Expand Up @@ -81,6 +81,5 @@
<%= link_to 'Back', projects_path, class: 'btn btn-default',
title: 'Return to projects page' %>
</p>
</div>
</div>

34 changes: 0 additions & 34 deletions apps/dashboard/app/views/projects/_template_select.html.erb
View file
Open in desktop

This file was deleted.

Loading