Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Handlebars from default label error messages #4063

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HazelGrant
Copy link
Contributor

No description provided.

@HazelGrant HazelGrant marked this pull request as ready for review January 9, 2025 14:40
@HazelGrant HazelGrant requested a review from johrstrom January 9, 2025 14:40

reportTransferTemplate(data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to check out what this looks like, but why not use the alert method in alert.js?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this looks & feels. Maybe there's some synergy with alert.js?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I could open a new ticket or we could handle here.

I think a few things

  • this should use alert.js (long term or in this PR)
  • I like the way the alert message is pre formatted, but not sure why it (the message) is toggle-able.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna go ahead and make the alert.js change in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants