Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ondemand and ondemand_dex package installs idempotent #217

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

sjpb
Copy link
Contributor

@sjpb sjpb commented Oct 20, 2023

The current defaults for ondemand_package and ondemand_dex_package aren't idempotent. This is problematic, as there is no way to get the behaviour of "install whatever the latest version is, then don't upgrade it on a rerun unless explicitly asked to". Note that that behaviour is the default yum/dnf behaviour.

This PR changes the behaviour of the defaults to be idempotent (hopefully that change is acceptable), and makes it so using latest is required to get an upgrade on an already-installed package.

The README changes have been made incorporating #215

@johrstrom
Copy link
Collaborator

Sorry for the delay - I was on vacation for a bit and now just have to remember that this is still on my plate- which it is.

I'll try to get this merged as soon as I can.

@johrstrom
Copy link
Collaborator

I'm looking into why tests are failing.

@johrstrom
Copy link
Collaborator

I cannot commit to your branch directly, so I cannot supply this patch myself. This is the diff you need to get the tests to work correctly. We have a test case for upgrading and as this changes the logic a bit, we need to account for that.

diff.txt

@sjpb
Copy link
Contributor Author

sjpb commented Nov 24, 2023

Sorry for the delay, was away.

@johrstrom
Copy link
Collaborator

Thanks for the update, no issues on your lag if there are no issues with my lag.

I am currently wondering if this can go now or if I should wait for 3.1 as it's a behavior change. Not a big one, but could impact current users. 3.1 is right around the corner, so it won't be long, but the fact that galaxy is (was) weird complicates it further.

@sjpb
Copy link
Contributor Author

sjpb commented Nov 29, 2023

Given it is a behaviour change, personally I'm happy to wait for it (especially if that's coming soon). Its not a blocker for me, but it will make behaviour easier to work with.

@johrstrom
Copy link
Collaborator

3.1 is being released today, so I'm going to merge this now for that release. Thanks again for the contribution!

@johrstrom johrstrom merged commit de2c05c into OSC:master Feb 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants