Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for specifying cores for the adapters that can support it #851

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

johrstrom
Copy link
Contributor

Add support for specifying cores for the adapters that can support it.

Fujitsu and SGE don't have support for this yet. SGE seems to need a variable to specify the parallel environment, which is unknown upfront. We'd have to issue a qconf command or similar to find the applicable string to use. Fujitsu I just can't seem to find the documentation for it.

I'll keep this open for just a second to write some tests for it.

@johrstrom
Copy link
Contributor Author

@mnakao can you point me to Fujitsu TCS documentation so I can add features like this? I'm trying to build support for specifying cores to the scheduler. After this I'm looking to add the ability to specify nodes.

@mnakao
Copy link
Contributor

mnakao commented Aug 13, 2024

@johrstrom
Looking at the changes to slurm, I saw that "-n" had been added, so I thought that the number of tasks (number of MPI processes) would be specified.
If so, use the syntax --mpi proc=X for Fujitsu TCS.

args.concat ["--mpi", "proc=" + script.cores] unless script.cores.nil?

For details, please refer to the Section 2.3.5.2 in "Job Operation Software End-user's Guide" at the URL below.
https://software.fujitsu.com/jp/manual/manualindex/p21000155e.html

Thanks,

@johrstrom
Copy link
Contributor Author

Thanks! I'll update the fujitsu adapter and keep that documentation handy for other updates.

@johrstrom johrstrom requested a review from HazelGrant December 18, 2024 17:33
@johrstrom johrstrom merged commit a6ee8e1 into master Dec 18, 2024
4 checks passed
@johrstrom johrstrom deleted the script-cores branch December 18, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants