-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for mellon auth #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull in Latest code
Add mellon auth
@treydock I've been using this in prod for well over an year, finally got around to push it upstream. |
@bp85 Generally I don't recommend deploying things that require manual steps, that somewhat defeats the purpose of Puppet. I think one way to achieve full automation is this:
|
I also see some hardcoded paths for Mellon defaults while other places use variables from Apache module. I think all paths should be defined in init.pp , and referenced downstream in various places using maybe the |
@treydock Let me know if this looks good or need any more changes. |
Left a few comments, as I think some changes made to this module in past few months are going to conflict with older changes here. |
accept changes Co-authored-by: treydock <treydock@gmail.com>
accept changes Co-authored-by: treydock <treydock@gmail.com>
@treydock can you review this PR again? I've made a few more changes accordingly. |
@treydock just checking in if you got time to review this! |
proxy_server
configuration option forood_portal.yml