Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Experimental Proxy Support to Edit-OSDCloud.winpe.ps1 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcohald
Copy link

It works in my Environment with a Proxy that does Basic Auth.
I'm not able to test it without a Proxy at the moment. But it should continue to work.

The Paramter addition to Test-WebConnection and Save-WebFile are not as beatufiull as I would like to have.
But i know no other Method to do it.
I'm happy if anyone can Point me in a Direction to configure the Proxy Settings in a Config File that the commands Test-WebConnection and Save-WebFile can read or anything like that.

@OSDeploy
Copy link
Owner

I'll start testing on this, but I agree, there should be a better way. Could this be done with a Global Variable possibly?

@marcohald
Copy link
Author

If I understand you right, you suggest to use the $global Prefix for each Proxy Configuration Option ?
Should I keep the Parameter for it in the Edit-OSDCloud.winpe function and set the Global Variables there ?
Should I use any specific prefix, so that they do not collide with Global Variables that a User has already set ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants