Minor bug fixing #46
Open
Minor bug fixing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zukedgwa
reviewed
Oct 25, 2022
| @@ -91,7 +91,7 @@ function Update-MyWindowsImage { | |||
| #================================================= | |||
| $global:GetWSUSXML = Get-WSUSXML -Catalog Windows -Silent | Sort-Object UpdateGroup -Descending | |||
|
|
|||
| if ($global:GetRegCurrentVersion.ReleaseId -gt 0) { | |||
| if ($global:GetRegCurrentVersion.DisplayVersion -gt 0) { | |||
There was a problem hiding this comment.
DisplayVersion may not always be an int. If you are looking for the minor version (revision) check out GetRegCurrentVersion.UBR.
|
Please be aware, that some values for GetRegCurrentVersion should be used with caution for Windows 11. Just check Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion on a Windows 11 client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'curl.exe' is not available, $WebClient cannot be assigned a new object [System.Net.WebClient] as it is already defined as [System.Management.Automation.SwitchParameter] in the param section. So for downloading updates successfully without 'curl.exe' I just renamed the variable to make sure the object can be created.
The If-Statement in Update-MyWindowsImage delivers the wrong registry field when reporting the found version.