Feature/smhe 1845 object config activity calendar #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 20, 2023 15:41
… object config message Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
… object config message Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
kroesctrl
requested changes
Nov 21, 2023
osgp/protocol-adapter-dlms/osgp-dlms/src/main/resources/dlmsprofiles/dlmsprofile-smr51.json
Outdated
Show resolved
Hide resolved
jboon
approved these changes
Nov 21, 2023
…ass for CosemObject Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
stefanermens
requested changes
Nov 21, 2023
osgp/protocol-adapter-dlms/osgp-dlms/src/main/resources/dlmsprofiles/dlmsprofile-dsmr22.json
Show resolved
Hide resolved
osgp/protocol-adapter-dlms/osgp-dlms/src/main/resources/dlmsprofiles/dlmsprofile-dsmr22.json
Outdated
Show resolved
Hide resolved
...src/test/java/org/opensmartgridplatform/dlms/services/objectconfig/ActivityCalendarTest.java
Outdated
Show resolved
Hide resolved
...ter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandActivationExecutor.java
Outdated
Show resolved
Hide resolved
...t/resources/features/osgp-adapter-ws-smartmetering/bundle/BundledSetActivityCalendar.feature
Outdated
Show resolved
Hide resolved
...er-dlms/osgp-dlms/src/main/java/org/opensmartgridplatform/dlms/objectconfig/CosemObject.java
Show resolved
Hide resolved
Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
kroesctrl
requested changes
Nov 21, 2023
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
...m/adapter/protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandExecutorTest.java
Outdated
Show resolved
Hide resolved
stefanermens
approved these changes
Nov 21, 2023
…ol class usage in command executors test Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
kroesctrl
requested changes
Nov 22, 2023
...protocol/dlms/domain/commands/datetime/SetActivityCalendarCommandActivationExecutorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andre Bolder <andre.bolder@alliander.com>
kroesctrl
approved these changes
Nov 22, 2023
|
Kudos, SonarCloud Quality Gate passed! |
jasperkamerling
deleted the
feature/SMHE-1845-object-config-activity-calendar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Activity Calendar Command Executers to the new Object Config Service.