Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NN1954 and NN2000 added to PROJ-data #46

Merged
merged 7 commits into from
Jan 5, 2021
Merged

NN1954 and NN2000 added to PROJ-data #46

merged 7 commits into from
Jan 5, 2021

Conversation

himsve
Copy link
Contributor

@himsve himsve commented Sep 25, 2020

No description provided.

@rouault
Copy link
Member

rouault commented Sep 25, 2020

Looks quite close to be ready: Two small observations valid for the 2 tiff files:

  • a warning to address if possible: "TIFF tag DateTime malformed. Should be YYYY:MM:DD HH:MM:SS"
  • Could I suggest to put the CRS names as well as the CRS code in TIFFTAG_IMAGEDESCRIPTION, like done for other grids ? For example instead of "EPSG:4937 to EPSG:5941. Converted from HREF2018B_NN2000_EUREF89.gtx." --> "EPSG:4937 (ETRS89) to EPSG:5941 (NN2000 height). Converted from HREF2018B_NN2000_EUREF89.gtx."

@rouault
Copy link
Member

rouault commented Oct 5, 2020

Anything left on your side ? This looks good to me otherwise

@meastp
Copy link

meastp commented Jan 5, 2021

@himsve @rouault Is this ready to merge now? :)

@rouault
Copy link
Member

rouault commented Jan 5, 2021

Is this ready to merge now? :)

The PR should be rebased on top of current master. There are conflicts in some generated files

@himsve
Copy link
Contributor Author

himsve commented Jan 5, 2021

The pull request should be ready for merging. The last update is to put to a branch named 'typo'.

@rouault rouault merged commit 63995e1 into OSGeo:master Jan 5, 2021
@rouault rouault added this to the 1.5 milestone Jan 5, 2021
@himsve himsve deleted the typo branch February 9, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants