Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official transformation of Hessen for the land survey register (ALKIS). #98

Merged
merged 53 commits into from
Mar 28, 2023

Conversation

ChristianMaierHVBG
Copy link
Contributor

This is the official transformation of Hessen for the land survey register (ALKIS).

I followed all the steps of contributing to PROJ-data. Hopefully everything works out.

I also registered the transformation before at epsg.org. You can find it here: https://epsg.org/transformation_9940/DHDN-to-ETRS89-11.html. I am not sure if this is enough for sql-files. Maybe there is still a manual addition necessary

*Source*: [HVBG Downloadcenter](https://www.gds.hessen.de/INTERSHOP/web/WFS/HLBG-Geodaten-Site/de_DE/-/EUR/ViewData-Start/1394640044?JumpTarget=ViewRequisitionProcess-Restart&IsOnlineBasket=false&ProductUUID=B9MKFwNVKxMAAAF.AeJVXZuMhttps://www.gds.hessen.de/INTERSHOP/web/WFS/HLBG-Geodaten-Site/de_DE/-/EUR/ViewData-Start/1394640044?JumpTarget=ViewRequisitionProcess-Restart&IsOnlineBasket=false&ProductUUID=B9MKFwNVKxMAAAF.AeJVXZuM)

*Format*: GeoTIFF converted from NTv2
*License*: Free redistribution is allowed and welcome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too vague as a license. We require the use of a well-known open data license such as the ones in https://github.com/OSGeo/PROJ-data#about-the-data-package. Other German geodetic agencies also sometimes use the "Data licence Germany - attribution - version 2.0"

The copyright_and_licenses.csv files should also be modified

Copy link
Contributor Author

@ChristianMaierHVBG ChristianMaierHVBG Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ok, we don't have any licence defined for it and there is nobody who is responsible for this topic. So I think we have to discard all this.

I also ask myself, why it is enough then for de_adv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have any licence defined for it and there is nobody who is responsible for this topic

Are you connected with the team that produced the file? Who is the owner of the intellectual property with it ? If it is you (your organization), then you can freely decide of the license for the data you deliver. CC-BY-4.0 (https://creativecommons.org/licenses/by/4.0/) is a quite popular open data license that a lot of geodetic agencies use for their grids. It cover all the open data freedoms while crediting the copyright owner of the data.

Copy link
Member

@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouault
Copy link
Member

rouault commented Mar 28, 2023

@ChristianMaierHVBG It seems you might be strugling with formatting of the readme ? For some reason, lines starting with *foo* should be terminated with 2 spaces. Anyway don't worry too much about that. We can fix that.
The main thing to do at that point would be to add new lines in copyright_and_licenses.csv for the readme and the grid

@ChristianMaierHVBG
Copy link
Contributor Author

Alright, we (my organization) decided to use the "Data licence Germany - attribution - version 2.0" aswell. I also modified the copyright_and_licenses.csv. Is there anything else I have to do now? Like you already mentioned, I am not really into GitHub, this is the first time I use it.

@rouault
Copy link
Member

rouault commented Mar 28, 2023

I also modified the copyright_and_licenses.csv

you probably forgot to git commit / push those changes

Is there anything else I have to do now?

that should be fine otherwise for this repository. In The OSGeo/PROJ repository, you also need to add a new line to link the .gsb grid name registerd in EPSG to the PROJ GeoTIFF one. Cf https://github.com/OSGeo/PROJ/blob/master/data/sql/grid_alternatives.sql#L99

@ChristianMaierHVBG
Copy link
Contributor Author

Now it should be updated.

copyright_and_licenses.csv Outdated Show resolved Hide resolved
@rouault rouault merged commit 7573161 into OSGeo:master Mar 28, 2023
@rouault rouault added this to the 1.14 milestone Mar 28, 2023
rouault added a commit to rouault/PROJ that referenced this pull request Mar 28, 2023
rouault added a commit to OSGeo/PROJ that referenced this pull request Apr 1, 2023
Database: register Hessen HeTA2010 grid (cf OSGeo/PROJ-data#98)
rouault added a commit to OSGeo/PROJ that referenced this pull request Apr 1, 2023
rouault added a commit to OSGeo/PROJ that referenced this pull request Apr 1, 2023
[Backport 9.2] Database: register Hessen HeTA2010 grid (cf OSGeo/PROJ-data#98)
clrpackages pushed a commit to clearlinux-pkgs/proj that referenced this pull request Nov 16, 2023
Addison Crump (1):
      Fuzzer: indicate discarded inputs

Alan Snow (1):
      BUG: Handle prefix whitespace when guessing WKT dialiect

Alexander Nehrbass (1):
      Add Polish geoid model PL-geoid2021

Andrew Annex (1):
      Adds Pseudo Mercator to build_db_from_iau.py

Even Rouault (91):
      NEWS: move bug fix mention from 9.1.1 to 9.2.0
      JSON/WKT: avoid precision issues on non-Intel architectures on coordinate epochs (fixes #3632)
      test/unit/test_io.cpp: change tests to avoid fp issues on some architectures (fixes #3632)
      test: proj_create_crs_to_crs_from_pj_force_over(): avoid use of uninitialized memory
      Database: add explicit casts to make sure all arms of columns selected by views have the same type affinity
      WKT_ESRI export: do not export NAD83 3D as NAD83(HARN)
      testvarious: do not output program name / versoin number
      Database: update to EPSG 10.083
      Fix build errors with Cygwin (fixes #3639)
      Database: update to EPSG 10.084
      pj_open_lib_internal(): rework to avoid false positive warnings of Coverity Scan / CSA about nullptr dereference
      proj_create_operations(): fix documentation related to 3D transformations (fixes #3651)
      PROJ string CRS parser: make sure that PROJ arguments of the rotated string are kept in the WKT representation (fixes #3654)
      [Performance regression fix] Fix slowness on proj_trans() on WGS 84 <--> NAD83 conversions
      .github/workflows/backport.yml: update with a BACKPORT_TOKEN from my (Even Rouault) account that has write permissions
      [Lint] projinfo: use const reference for for argument (CID 396530)
      Use ghcr.io/osgeo/proj-docs as Docker hub is sunsetting free organizations (refs OSGeo/gdal#7447)
      vgridshift/gridshift: accept hydroid_height as valid band description
      WKT/PROJJSON: import/export accuracy of ConcatenatedOperation
      Coord. operation factory: count identified concatenated operations as a single step
      Doc: fix search functionnality
      Database: add alias for old ESRI datum/CRS names of EPSG:8353 S_JTSK_JTSK03_Krovak_East_North
      EngineeringCRS: make proj_create_engineering_crs() set a datum name, and relax isEquivalentTo() comparisons to deal with case of r-spatial/sf#2049 (comment)
      Database: register Hessen HeTA2010 grid (cf OSGeo/PROJ-data#98)
      Database: update to EPSG 10.085
      Database: register grids for New Caledonia (added per OSGeo/PROJ-data#99)
      createOperations(): tune to get better results in some cases, typically RGNC91-93 to RGNC15
      PROJJSON: fix import/export of integer parameter value, and deal with interpolation CRS parameters in conversions (fixes #3689)
      CMake: avoid imbalanced cmake_policy push/pop if TIFF or CURL dependency cannot be found (fixes #3696)
      Database: refresh IAU CRS with addition of Pseudo Mercator ones
      Fix code format
      C++ API: add a CoordinateTransformer class, and CoordinateOperation::coordinateTransformer() (refs #3593)
      Doc: remove empty page
      pj_obs_api_mini_demo.c: remove header comments non-essential IMHO for the beginner and reflecting more historical evolution
      CMakeLists.txt: distribute examples
      Add build support for the examples/ programs (disabled by default, unless -D BUILD_EXAMPLES=ON is set)
      Doc: add a C++ quickstart (fixes #3593)
      createOperationsVertToVert(): assign an extent
      DatabaseContext::lookForGridInfo(): deal with special 'null' grid
      proj_create_crs_to_crs(): restore behaviour of PROJ 9.1
      Database: update to EPSG 10.086
      Add code comment about likely domain of validity for wintri in +over mode
      Import from ESRI WKT: remove special case of renaming UPS_North / UPS_South which appears to be undesirable
      WKT ESRI: recognize Polar_Stereographic_Variant_A method name which is used in the official ESRI formulation of EPSG:5041 and EPSG:5042
      Database: update to EPSG 10.087
      Fix unreleased regression related to 78d563c97f4920c58a4f04d4a5058df41720fd8c, that caused GDAL's test_gdalwarp_lib_135 test to fail
      CRS instanciation from PROJ.4 string: set 'Unknown based on XXXX ellipsoid' datum name...
      cs2cs / proj_create_crs_to_crs(): fix regression with geocentric CRS
      Doc: proj_create_crs_to_crs_from_pj(): formatting fix
      proj_trans(): set PROJ_ERR_COORD_TRANSFM_NO_OPERATION error when failing in ONLY_BEST=YES mode
      Database: update to EPSG 10.088
      Add support for EPSG:1102 'Lambert Conic Conformal (1SP variant B)' method, and import related EPSG records
      tinshift: raise maximum size of JSON file to 100 MB (fixes #3732)
      Add +R_C as an ellipsoid spherification parameter to use the radius of the conformal sphere
      Map EPSG:1026 Mercator (Spherical) method to +proj=merc +R_C
      CMake: remove useless cross-compiling related checks (fixes #3746)
      omerc: catch invalid value of gamma (when specified without alpha)
      Merge pull request #3757 from jidanni/patch-8
      proj.ini: set default values of parameter to be consistent, and some missing documentation
      CMake: build fuzzers in standalone mode as part of BUILD_TESTING
      GeographicBoundingBox::intersection(): avoid infinite recursion and stack overflow on invalid bounding boxes
      metadata.sql: update PROJ_DATA.VERSION to 1.15
      Fix proj-config.cmake to not try including proj4-targets.cmake in INSTALL_LEGACY_CMAKE_FILES=OFF mode
      omerc.rst: fix example (fixes #3794)
      Database: update to EPSG v10.091
      Equidistant Conic: add mapping to new EPSG:1119 method
      proj_db_table_defs.sql: add EPSG_1026_Mercator (Spherical)
      Fix -Wunused-but-set-variable with recent clang in bison generated parsers
      ConcatenatedOperation::fixStepsDirection(): fix detection of geocentric CRS which wrongly detected geographic 3D CRS too
      fixStepsDirection(): pass database context
      Add a way to skip inconsistently defined operations in createFromCoordinateReferenceSystemCodes() and createFromCRSCodesWithIntermediates()
      factory.cpp: include authority name in exception
      fixStepsDirection(): enable to define a concatenated operationg ending with a NADCOND (3D) transformation (use case of refs #3819)
      exportToPROJString(): when a NADCON operation is included in a vertical transformation, do not include axis swap
      proj_factors(): make it work with projected CRS with non-metre unit and/or northing/easting axis order (fixes #3824)
      Database: update to EPSG 10.093
      Projected CRS identification: fix crash when the base CRS is a non-geographic geodetic CRS (fixes #3828)
      Doc: fix links to geoapi
      Avoid C++ exceptions to be thrown (and caught) when parsing strings like '+proj=longlat +datum=WGS84 +type=crs'
      pj_hgrid_apply_internal(): use pj_log() infrastructure
      PROJ_DEBUG: make ON an alias of 2, and OFF of 1 (fixes #3832)
      ConcatenatedOperation::fixStepsDirection(): fix logic error (Coverity CID 416067)
      CoordinateOperation::targetCoordinateEpoch(): use std::move() to avoid copy (CID 406913)
      proj_alter_id(): make it replace an existing ID instead of appending a new one
      Database: update to EPSG 10.094
      bonne: fix inverse map projection computations when lat_1 < 0 (fixes #3848)
      WKT1 ESRI import/export: fix GCS name for EPSG:8353 S-JTSK_[JTSK03]_Krovak_East_North
      Database: grid_alternatives: reference new HT2 Canadian grids added per OSGeo/PROJ-data#106
      Fix false-positive compiler warning
      JSON export: avoid non-significant decimal digits in version field (fixes #3863)
      JSON import: reduce number of significant decimal digits when parsing id.version field (fixes #3863, reworks previous commit)

Hannes (1):
      Fix typo "geograpic" -> "geographic" in logging/error output

Javier Jimenez Shaw (7):
      add GEOIDE-Ar16.gri in grid_alternatives.sql as ar_ign_GEOIDE-Ar16.tif
      Add option in proj CLI to use a CRS (#3825)
      Use NS_PROJ namespace (fixes #3842, master only) (#3843)
      Docker: update base image to ubuntu:22.04 [ci skip]
      Mention derived projected in operations_computation
      Doc docker: limit sphinxcontrib-spelling version. Breaking changes in v8
      Doc docker: remove conflictive dependency awscli

Jean-Christophe Malapert (2):
      Update build_db_from_iau.py
      Add new projection : Mercator (Spherical)

Kristian Evers (11):
      Update website for 9.2.0 release
      Bump version numbers in anticipation of 9.3.0 release
      Add Danish grid files to grid_alternatives
      Update NEWS for 9.2.1 release
      Update website for 9.2.1 release
      Add stale GitHub action, as replacement for old stale GitHub integration
      Merge pull request #3803 from jidanni/patch-33
      Update .github/workflows/stale.yml
      Update man-pages from Sphinx-docs
      Update man-pages from Sphinx-docs
      Update NEWS for 9.3.0

Mike Taves (13):
      Update clang static analyzer CI and docs for ubuntu-22.04
      CI: update ubuntu images, actions/checkout, actions/cache, unique job IDs (#3649)
      CI: update other actions, use apt-get for scripts
      CMake: add PROJ_DB_CACHE_DIR
      CI: upgrade vcpkg tag used for AppVeyor; use --triplet option
      resolve MSVC warnings C4800
      CI: use PROJ_DB_CACHE_DIR (#3717)
      CI: Clean-up Travis CI scripts and files related to publishing docs
      Doc/CI: Transition to ReadTheDocs, clean-up previous methods
      CMake: add /disabled_workflows/ to CPACK_SOURCE_IGNORE_FILES [ci skip]
      Docs: refactor Python code for sphinx configuration and extensions (#3761)
      plot.py: rewrite using shapely>=2 (#3811)
      ReadTheDocs: add htmlzip to offline formats; remove ePub (#3810)

Thomas Knudsen (1):
      Deformation: Make code and comments compatible

積丹尼 Dan Jacobson (5):
      Simplify eqc.rst example (#3755)
      Update ellipsoids.rst to mention default
      Update proj.rst example to modern usage (#3754)
      omerc.rst: add comparison with spherical tmerc (#3752)
      Update y_0.rst (#3797)

9.3.0 Release Notes
-------------------

 Updates
 -------

 o Add C++ API to transform coordinate (#3705)

 o CMake: add PROJ_DB_CACHE_DIR (#3711)

 o Implement EPSG:1026 Mercator (Spherical) method (#3741)

 o CMake: remove useless cross-compiling related checks (#3747)

 o Add mapping of Equidistant Conic to new EPSG:1119 method (#3812)

(NEWS truncated at 15 lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants